Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove legacy code #7

Merged
merged 18 commits into from
Oct 4, 2023
Merged

feat: remove legacy code #7

merged 18 commits into from
Oct 4, 2023

Conversation

mpetrun5
Copy link

@mpetrun5 mpetrun5 commented Oct 2, 2023

Removes all legacy code that is not used.
Changes:

  • mocks are now in root mock package to make it easier to test and find them
  • all deposit, event and message handlers are exepected to be written in the package that uses core package
  • config is removed and expected to be implemented by the relayer
  • packages rearranged where it makes sense
  • Proposal and Message moved to root package types and expected to be used by all implemented chains (format will be changed in the upcoming refactors)
  • msgChan removed from being passed to listener and expected to be passed to specific handlers to facilitate future refactor of arbitrary messages between chains
  • CLI removed
  • logger and Opentelemetery moved to observability (waits for upcoming tracing union of it)

Description

Related Issue Or Context

Closes: #6

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Go Test coverage is 63.2 %\ ✨ ✨ ✨

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Go Test coverage is 63.2 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 requested a review from nmlinaric October 3, 2023 14:30
@mpetrun5 mpetrun5 merged commit 4e1c654 into main Oct 4, 2023
7 checks passed
@mpetrun5 mpetrun5 deleted the remove-legacy-code branch October 5, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup legacy
4 participants